Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dep] Bump upload-artifact github action #1242

Merged
merged 3 commits into from
Mar 19, 2024
Merged

[dep] Bump upload-artifact github action #1242

merged 3 commits into from
Mar 19, 2024

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Mar 19, 2024 •
edited
Loading

What and why?

Fixes these warnings:

image

How?

Bumping github actions.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@Drarig29 Drarig29 added the chores Related to the CI or developer experience label Mar 19, 2024
@Drarig29 Drarig29 requested a review from a team as a code owner March 19, 2024 09:57
@Drarig29 Drarig29 marked this pull request as draft March 19, 2024 09:59
@Drarig29 Drarig29 marked this pull request as ready for review March 19, 2024 10:24
teodor2312
teodor2312 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@teodor2312 teodor2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but out of curiosity how can you test this that the change is working 🤔

@Drarig29
Copy link
Contributor Author

Drarig29 commented Mar 19, 2024 •
edited
Loading

@teodor2312 it failed previously, and the CI failed (see the first commit).

When it started to work, I downloaded the artifacts to ensure we were keeping the right behavior:

  • For the artifacts folder, we want to have each a .tgz for datadog-ci in each Node.js version ✅
  • For the sarif-datadog-ci.sarif, it's just for us to manually download in case the linting fails, so it's OK for it to be overwritten (it's the old behavior) ✅

@Drarig29 Drarig29 merged commit 35c54e1 into master Mar 19, 2024
15 checks passed
@Drarig29 Drarig29 deleted the corentin.girard/update-upload-artifact-actions branch March 19, 2024 13:33
@dastrong dastrong mentioned this pull request Mar 26, 2024
Merged
@Drarig29 Drarig29 mentioned this pull request May 22, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-fernandez juan-fernandez juan-fernandez approved these changes

@teodor2312 teodor2312 teodor2312 approved these changes

Assignees
No one assigned
Labels
chores Related to the CI or developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drarig29 @juan-fernandez @teodor2312