Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbom): detect npm from purl #1244

Merged
merged 5 commits into from
Mar 25, 2024
Merged

fix(sbom): detect npm from purl #1244

merged 5 commits into from
Mar 25, 2024

Conversation

omercnet
Copy link
Contributor

@omercnet omercnet commented Mar 19, 2024 •
edited
Loading

What and why?

fixes #1243

How?

If npm does not exist in bom-ref also check purl

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@omercnet omercnet marked this pull request as ready for review March 19, 2024 12:36
@omercnet omercnet requested a review from a team as a code owner March 19, 2024 12:36
@omercnet omercnet requested a review from dastrong March 19, 2024 12:36
juli1
juli1 requested changes Mar 19, 2024
View reviewed changes
src/commands/sbom/language.ts Show resolved Hide resolved
src/commands/sbom/__tests__/fixtures/sbom.1.5.ok.json Outdated Show resolved Hide resolved
@omercnet omercnet requested a review from juli1 March 19, 2024 13:50
juli1
juli1 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@juli1 juli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for addressing the comments 🙏

@omercnet
Copy link
Contributor Author

@dastrong can you take a look?

@dastrong dastrong added the static-analysis Related to [sarif, sbom] label Mar 25, 2024
@dastrong dastrong merged commit bbf3074 into DataDog:master Mar 25, 2024
3 checks passed
@Drarig29 Drarig29 mentioned this pull request Mar 25, 2024
Merged
1 task
@dastrong dastrong mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juli1 juli1 juli1 approved these changes

@dastrong dastrong dastrong approved these changes

Assignees
No one assigned
Labels
static-analysis Related to [sarif, sbom]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

components generated by cyclonedx/cyclonedx-npm are not detected properly
3 participants
@omercnet @juli1 @dastrong