[lambda] support dotnet8 and java21 runtimes
#1249
Merged
+2,519
−2,637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport for these runtimes
duncanista
changed the title
dotnet8 and java21 runtimes
Datadog ReportBranch report: ✅ 0 Failed, 8088 Passed, 0 Skipped, 44.21s Wall Time |
Drarig29
reviewed
Mar 28, 2024
There was a problem hiding this comment.
I took the liberty to edit your PR: I don't want to have skipLibCheck: true because datadog-ci is a library itself. So, if we let the typecheck fail in the libraries we use, we might introduce build issues in our users' projects 😬
And apparently, the actual issue here was our definition of paths. So I removed it, and typeRoots as well because it was outdated: we don't have a ./src/types.ts file anymore.
There was a problem hiding this comment.
Thanks a lot for taking a look at this @Drarig29 !
joeyzhao2018
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Adds support for dotnet8 and java21
closes #1247
How?
Just added it to the allowlist and bumped dependencies and resolved issues where methods moved packages.
Notes
Review checklist