-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lambda] support dotnet8
and java21
runtimes
#1249
Conversation
…pport for these runtimes
dotnet8
and java21
runtimes
Datadog ReportBranch report: ✅ 0 Failed, 8088 Passed, 0 Skipped, 44.21s Wall Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to edit your PR: I don't want to have skipLibCheck: true
because datadog-ci is a library itself. So, if we let the typecheck fail in the libraries we use, we might introduce build issues in our users' projects 😬
And apparently, the actual issue here was our definition of paths
. So I removed it, and typeRoots
as well because it was outdated: we don't have a ./src/types.ts
file anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking a look at this @Drarig29 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What and why?
Adds support for dotnet8 and java21
closes #1247
How?
Just added it to the allowlist and bumped dependencies and resolved issues where methods moved packages.
Notes
Review checklist