check rule existence in extensions #1434
Merged
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 1656 Passed, 0 Skipped, 2m 1.35s Total duration (1m 25.7s time saved) |
amaanq
approved these changes
Sep 3, 2024
Drarig29
approved these changes
Sep 3, 2024
| @@ -58,6 +58,18 @@ export const checkForError = (filePath: string): string[] => { | |||
| } | |||
| } | |||
| } | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access | |||
There was a problem hiding this comment.
That's not ideal, but the whole function does that so I'll let it pass. It could be better typed in the future 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
We check that the SARIF file is valid to check that all rules are defined. We currently check in the tool section and not in the extensions. When processing a SARIF file that does have rules in extensions, it fails.
How?
Detect rules in extensions