Add explicit function return type for Lambda and Step Function code #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
force-pushed
the
yiming.luo/step-function-refactor
branch
from
1502bf9
to
f2c1a96
Compare
lym953
changed the title
lym953
added
serverless
Datadog ReportBranch report: ✅ 0 Failed, 1592 Passed, 0 Skipped, 1m 59.29s Total duration (1m 28.39s time saved) |
kimi-p
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Add explicit return type for most functions in
src/commands/lambdasrc/commands/stepfunctionsto make code more readable, improving developer experience.
The return type for some functions is complicated (>= 4 lines long), and I'm not adding explicit return type for them because I think it would make code verbose and less readable.
How?
N/A
Testing
No new failure in
npm testReview checklist