Refactor sfn->sfn context injection code by merging two functions (2) #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
added
serverless
Datadog ReportBranch report: ✅ 0 Failed, 432 Passed, 0 Skipped, 1m 32.14s Total duration (2m 1.75s time saved) |
lym953
force-pushed
the
yiming.luo/fix-step-func-14
branch
from
575e459
to
682a7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Merge
addTraceContextToStepFunctionParameters()into its callsites, and removing the extraifchecks.Why
Depending on the original state
Input, we will have different instrumentation strategies, so a singleaddTraceContextToStepFunctionParameters()will no longer work.Testing
Run
npm testto pass existing testsReview checklist