Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sfn->sfn context injection case 3 #1468

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

lym953
Copy link
Contributor

@lym953 lym953 commented Sep 23, 2024

What and why?

Skip the context injection in Step Function execution step if the CONTEXT field exists and it's not an object.

This is case # 2 in this design doc: Fixing Step Function Instrumentation

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)

@lym953 lym953 requested review from a team as code owners September 23, 2024 18:54
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Sep 23, 2024

Datadog Report

Branch report: yiming.luo/fix-step-func-15
Commit report: 1285c5a
Test service: datadog-ci-tests

✅ 0 Failed, 432 Passed, 0 Skipped, 1m 32.78s Total duration (2m 1.11s time saved)

@lym953 lym953 added enhancement New feature or request serverless Related to [lambda, stepfunctions, cloud-run] labels Sep 23, 2024
Copy link
Contributor

@avedmala avedmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

Base automatically changed from yiming.luo/fix-step-func-14 to master September 25, 2024 20:51
@lym953 lym953 merged commit d36a07e into master Sep 25, 2024
18 checks passed
@lym953 lym953 deleted the yiming.luo/fix-step-func-15 branch September 25, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request serverless Related to [lambda, stepfunctions, cloud-run]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants