Read pull_request and pull_request_target event info from GHA #1473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
GitHub does not run workflows in the head of the branch about to be merged whenever the workflow is triggered through
pull_request
orpull_request_target
events. It runs them in a merge commit. This is the one that we add togit.commit.sha
. This is sometimes confusing because this commit does not exist in the history of the branch. What we did:git.commit.head_sha
, which is the head SHA of the feature branch (branch to be merged).git.pull_request.base_branch_sha
, which is the head SHA of the base branch (branch you're merging into)git.pull_request.base_branch
, which is the name of the base branchHow?
Detect if we're in a
pull_request
orpull_request_target
event by checkingGITHUB_BASE_REF
, and if we are, attempt to read theevent.json
payload made available by GitHub inGITHUB_EVENT_PATH
.Review checklist