-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SVLS-5714] Add lambda network enhanced metrics #424
[SVLS-5714] Add lambda network enhanced metrics #424
Conversation
@@ -375,6 +375,9 @@ async fn extension_loop_active( | |||
request_id, deadline_ms, invoked_function_arn | |||
); | |||
lambda_enhanced_metrics.increment_invocation_metric(); | |||
let mut p = invocation_processor.lock().await; | |||
p.on_invoke_event(request_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder since this is always invoked first, if we might need to change the constructor for the context buffer, simplifying our logic. As I'm not sure if this would guarantee us to always have this operation to exist before any other hook from the telemetry API, we might need some experiment to check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a discussion about this with Jordan, will do in a future PR!
Amazing work, this is taking a much much better form! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some non-blocking comments! Amazing work
ada1414
into
jordan.gonzalez/bottlecap/universal-instrumentation
What does this PR do?
This PR introduces three new enhanced lambda metrics. Each of the metrics are emitted once per invocation and represent network usage by the lambda function.
The three new metrics are:
aws.lambda.enhanced.rx_bytes
- bytes received by the functionaws.lambda.enhanced.tx_bytes
- bytes transmitted by the functionaws.lambda.enhanced.total_network
- sum ofaws.lambda.enhanced.rx_bytes
andaws.lambda.enhanced.tx_bytes
Describe how to test/QA changes
Additional Notes