[SVLS-5714] Add lambda network enhanced metrics #424

shreyamalpani · 2024-10-22T21:36:40Z

What does this PR do?

This PR introduces three new enhanced lambda metrics. Each of the metrics are emitted once per invocation and represent network usage by the lambda function.

The three new metrics are:

aws.lambda.enhanced.rx_bytes - bytes received by the function
aws.lambda.enhanced.tx_bytes - bytes transmitted by the function
aws.lambda.enhanced.total_network - sum of aws.lambda.enhanced.rx_bytes and aws.lambda.enhanced.tx_bytes

Describe how to test/QA changes

Build the lambda extension
Create a lambda function with the extension built in previous step
Turn on lambda insights / add the lambda insights extension to your function
Invoke the function
View the new enhanced metrics in metrics explorer or this dashboard
Compare with lambda insight metrics

Additional Notes

Will implement the structure to store the offsets for the different types of metrics together in the next PR

bottlecap/src/proc/mod.rs

bottlecap/src/metrics/enhanced/lambda.rs

bottlecap/src/proc/mod.rs

bottlecap/src/metrics/enhanced/lambda.rs

duncanista · 2024-10-23T16:58:33Z

bottlecap/src/bin/bottlecap/main.rs

@@ -375,6 +375,9 @@ async fn extension_loop_active(
                    request_id, deadline_ms, invoked_function_arn
                );
                lambda_enhanced_metrics.increment_invocation_metric();
+                let mut p = invocation_processor.lock().await;
+                p.on_invoke_event(request_id);


Wonder since this is always invoked first, if we might need to change the constructor for the context buffer, simplifying our logic. As I'm not sure if this would guarantee us to always have this operation to exist before any other hook from the telemetry API, we might need some experiment to check!

Had a discussion about this with Jordan, will do in a future PR!

duncanista · 2024-10-23T16:59:50Z

Amazing work, this is taking a much much better form! 🎉

bottlecap/src/proc/mod.rs

duncanista

Left some non-blocking comments! Amazing work

send network enhanced metrics

1ca5f58

shreyamalpani requested a review from a team as a code owner October 22, 2024 21:36