fix incorrect gc types in newer versions of node #61
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
test/metrics.spec.js
Outdated
| @@ -51,8 +53,10 @@ describe('metrics', () => { | |||
| expect(stats.eventLoop).to.have.property('p95') | |||
| expect(stats.eventLoop.p95).to.be.a('number') | |||
|
|
|||
| console.log(stats.gc) | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
Unexpected console statement. (...read more)
Debugging with console (such as console.log or console.info) is not considered a bad practice, but these statements can be accidentally left in production code, leading to unnecessary log pollution. It is important to remove or replace these debugging statements to maintain clean and secure production builds.
|
Good to know I wasn't crazy :) |
test/metrics.spec.js
Outdated
| @@ -7,6 +7,7 @@ const nativeMetrics = require('..') | |||
|
|
|||
| describe('metrics', () => { | |||
| beforeEach(() => { | |||
| console.log('js:', process.version) | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
Unexpected console statement. (...read more)
Debugging with console (such as console.log or console.info) is not considered a bad practice, but these statements can be accidentally left in production code, leading to unnecessary log pollution. It is important to remove or replace these debugging statements to maintain clean and secure production builds.
Overall package sizeSelf size: 1.24 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | node-addon-api | 6.1.0 | 393.77 kB | 393.77 kB | | node-gyp-build | 3.9.0 | 8.81 kB | 8.81 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Inspired by #52, thanks @ikonst!