fix max int generation on web to use -1 >> 0

[a-h-mzd]

What and why?

When running flutter apps compiled to JS, 1 << 32 results in 0 instead of the max int allowed for random number generation.

How?

According to this we can use -1 >> 0 to achieve what is needed.

Review checklist

• This pull request has appropriate unit and / or integration tests
• This pull request references a Github or JIRA issue

[fuzzybinary]

Hi @a-h-mzd ,

Thanks for taking the time to create a PR.

Are you seeing something behave incorrectly? I'm pretty sure this tracer is actually only used in native platforms, not in Web where we rely on the Datadog Browser SDK's tracing implementation.

[a-h-mzd]

@fuzzybinary thank you for the quick response.

TracingContext.generateTracingContext is actually used by the plugins(like datadog_gql_link and datadog_grpc_interceptor). I have also created a new package which contains an interceptor for Dio based on the implementation found in datadog_gql_link. I will create a PR for it soon.

[fuzzybinary]

👍 I'll still have to double check that the Browser SDK doesn't handle those calls internally anyway. It would be better if we had a failing test or repro case to work from to start.

[a-h-mzd]

It’s actually pretty easy to test. Just try to print 1 << 32 and run the code in the browser or just compile it to JS. You’ll see that 1 << 32 is converted to 0.

[fuzzybinary]

Yes, I'm more referring to showing that using the grpc or gql interceptors on web does not produce the desired results. The actual feature is that distributed tracing in these packages works on web. 1 << 32 is an implementation detail and the cause of the bug.