Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing(aws-sdk): improve sqs dsm tracing experience #4425

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

wconti27
Copy link
Contributor

Changes a few small things with AWS SQS Tracing:

  • Updates SQS receiveMessage attributes to always return injected _datadog attributes (used for DSM / APM Trace context propagation)
  • Updates SQS to always extract DSM context even if no callback is used. Previously, DSM extraction only happens if the receiveMessage function was called with a callback. Since we have all the information necessary to extract DSM context without using a callback and do not need any context storing, we can extract the context for await <receiveMessage>.promise() call styles.

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

…context in request complete if no callback is used
@wconti27 wconti27 requested review from a team as code owners June 21, 2024 17:16
@wconti27 wconti27 changed the title ensure datadog attributes are received by sqs and set DSM extraction … tracing(aws-sdk): improve DSM tracing experience Jun 21, 2024
@wconti27 wconti27 changed the title tracing(aws-sdk): improve DSM tracing experience tracing(aws-sdk): improve sqs dsm tracing experience Jun 21, 2024
Copy link

github-actions bot commented Jun 21, 2024

Overall package size

Self size: 6.72 MB
Deduped: 61.98 MB
No deduping: 62.26 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.8.1 71.67 kB 741.34 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jun 21, 2024

Benchmarks

Benchmark execution time: 2024-06-24 15:13:43

Comparing candidate commit 70c2b7f in PR branch conti/aws-dsm-improvements with baseline commit 225b79e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (b1f1f85) to head (c3dc5f8).
Report is 10 commits behind head on master.

Current head c3dc5f8 differs from pull request most recent head e94b69a

Please upload reports for the commit e94b69a to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4425       +/-   ##
===========================================
- Coverage   92.64%   78.99%   -13.65%     
===========================================
  Files         116      249      +133     
  Lines        4173    10719     +6546     
  Branches       33       33               
===========================================
+ Hits         3866     8468     +4602     
- Misses        307     2251     +1944     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Qard
Qard previously approved these changes Jun 21, 2024
@wconti27 wconti27 self-assigned this Jun 24, 2024
@wconti27 wconti27 requested a review from Qard June 24, 2024 15:12
@wconti27 wconti27 merged commit e939d31 into master Jun 24, 2024
133 of 134 checks passed
@wconti27 wconti27 deleted the conti/aws-dsm-improvements branch June 24, 2024 18:35
juan-fernandez pushed a commit that referenced this pull request Jul 10, 2024
* ensure datadog attributes are received by sqs and set DSM extraction context in request complete if no callback is used
juan-fernandez pushed a commit that referenced this pull request Jul 10, 2024
* ensure datadog attributes are received by sqs and set DSM extraction context in request complete if no callback is used
@wconti27 wconti27 mentioned this pull request Jul 10, 2024
@juan-fernandez juan-fernandez mentioned this pull request Jul 11, 2024
juan-fernandez pushed a commit that referenced this pull request Jul 11, 2024
* ensure datadog attributes are received by sqs and set DSM extraction context in request complete if no callback is used
juan-fernandez pushed a commit that referenced this pull request Jul 11, 2024
* ensure datadog attributes are received by sqs and set DSM extraction context in request complete if no callback is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants