Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): implement protobufjs DSM schema support #4701

Merged
merged 28 commits into from
Oct 4, 2024

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Sep 18, 2024

What does this PR do?

Adds ProtobufJS schema support for DSM. Also adds an abstract schema plugin, which will be used for abstraction when adding additional schema plugins

Motivation

Plugin Checklist

Additional Notes

@wconti27 wconti27 requested review from a team as code owners September 18, 2024 20:32
Copy link

github-actions bot commented Sep 18, 2024

Overall package size

Self size: 7.34 MB
Deduped: 62.75 MB
No deduping: 63.03 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 9.0.0 | 580.4 kB | 1.03 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@wconti27 wconti27 changed the title Conti/support protobuf schemas feat(tracing): implement protobufjs DSM schema support Sep 19, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2024

Benchmarks

Benchmark execution time: 2024-10-04 14:18:57

Comparing candidate commit af77ce5 in PR branch conti/support-protobuf-schemas with baseline commit d024777 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 8 unstable metrics.

@wconti27 wconti27 self-assigned this Sep 19, 2024
Copy link

@ericfirth ericfirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (minus the commented out tests)

packages/datadog-plugin-protobufjs/test/index.spec.js Outdated Show resolved Hide resolved
ericfirth
ericfirth previously approved these changes Sep 24, 2024
ericfirth
ericfirth previously approved these changes Sep 24, 2024
@wconti27 wconti27 requested a review from bengl September 25, 2024 16:58
@wconti27 wconti27 requested a review from tlhunter October 3, 2024 13:46
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.99%. Comparing base (bb0bbcc) to head (da15fc1).
Report is 19 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4701       +/-   ##
===========================================
- Coverage   91.42%   64.99%   -26.44%     
===========================================
  Files         112       63       -49     
  Lines        3475     2565      -910     
  Branches       33       33               
===========================================
- Hits         3177     1667     -1510     
- Misses        298      898      +600     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/datadog-instrumentations/src/protobufjs.js Outdated Show resolved Hide resolved
packages/datadog-instrumentations/src/protobufjs.js Outdated Show resolved Hide resolved
packages/datadog-instrumentations/src/protobufjs.js Outdated Show resolved Hide resolved
@wconti27 wconti27 requested a review from bengl October 3, 2024 18:12
@wconti27 wconti27 merged commit 08525d4 into master Oct 4, 2024
195 checks passed
@wconti27 wconti27 deleted the conti/support-protobuf-schemas branch October 4, 2024 14:57
tlhunter pushed a commit that referenced this pull request Oct 7, 2024
bengl pushed a commit that referenced this pull request Oct 16, 2024
bengl pushed a commit that referenced this pull request Oct 16, 2024
This was referenced Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants