Profiler shouldn't retry some HTTP requests when sending profiles #4823
+46
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Disables retries when profiler tries to submit profiles when it receives any of the 4xx Client Error class of HTTP status codes in responses, with the notable exception of 429 which can be retried.
Motivation
Current retry logic will keep retrying on 4xx status codes. By and large requests that were answered with a 4xx error will be answered with the same error when retried without changes. This can have undesirable effects, such as delaying shutdown of the application if the agent keeps sending back a 4xx error.
Additional Notes
JIRA PROF-10807