Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache_key_enabled option for ActiveSupport #4022

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Add cache_key_enabled option for ActiveSupport #4022

wants to merge 8 commits into from
+164 −2

Commits on Oct 23, 2024

  1. Add cache_key_enabled option for ActiveSupport

    @bouwkast
    bouwkast committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e8188fc View commit details
    Browse the repository at this point in the history

  2. Copy/paste tests

    @bouwkast
    bouwkast committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e87ed63 View commit details
    Browse the repository at this point in the history

  3. Use shorthand configuration access 

    Co-authored-by: Marco Costa <[email protected]>
    @bouwkast @marcotc
    bouwkast and marcotc authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1f31567 View commit details
    Browse the repository at this point in the history

  4. Limit tested behavior to just cache_key expects 

    Co-authored-by: Marco Costa <[email protected]>
    @bouwkast @marcotc
    bouwkast and marcotc authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    eb19f98 View commit details
    Browse the repository at this point in the history

  5. Wrap reads with it do

    @bouwkast
    bouwkast committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4197b1a View commit details
    Browse the repository at this point in the history

  6. Fix linting errors

    @bouwkast
    bouwkast committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1c823a0 View commit details
    Browse the repository at this point in the history

  7. Revert "Use shorthand configuration access" 

    This reverts commit 1f31567.

This didn't work.
    @bouwkast
    bouwkast committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    866c888 View commit details
    Browse the repository at this point in the history

  8. Reapply "Use shorthand configuration access" 

    This reverts commit 866c888.

It's missing a require_relative
    @bouwkast
    bouwkast committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    45ef5e6 View commit details
    Browse the repository at this point in the history