Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buggy chmod directive #1180

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Remove buggy chmod directive #1180

merged 3 commits into from
Nov 7, 2023

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Sep 22, 2023

What this PR does / why we need it:

Remove a buggy

chmod -R 744 /etc/datadog-agent

in the init container of the cluster agent:

  • it recursively sets the execution bit for the user, even on non-executable, non-directory files.
  • it doesn’t set the directory search bit for group and others on directories.

This chmod was introduced by #1096 to workaround an issue introduced by DataDog/datadog-agent#16347 and DataDog/datadog-agent#18069.
Let’s rather fix the issue at its root cause: inside the docker image thanks to DataDog/datadog-agent#19673.

Which issue this PR fixes

  • fixes CONS-5810

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

charts/datadog/CHANGELOG.md Outdated Show resolved Hide resolved
@L3n41c L3n41c enabled auto-merge (squash) November 7, 2023 11:45
@L3n41c L3n41c merged commit ebae161 into main Nov 7, 2023
14 checks passed
@L3n41c L3n41c deleted the lenaic/CONS-5810 branch November 7, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants