Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APMON-284] Add support of APM Single Step Instrumentation in helm #1211

Closed
wants to merge 21 commits into from

Conversation

liliyadd
Copy link
Contributor

@liliyadd liliyadd commented Oct 19, 2023

What this PR does / why we need it:

Starting from release 7.49.x, cluster agent supports Single Step Instrumentation. This change allows configuring Single Step Instrumentation during agent installation with Helm.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@liliyadd liliyadd requested a review from a team October 19, 2023 20:17
@liliyadd liliyadd requested a review from a team as a code owner October 19, 2023 20:17
charts/datadog/CHANGELOG.md Outdated Show resolved Hide resolved
charts/datadog/CHANGELOG.md Outdated Show resolved Hide resolved
charts/datadog/README.md Outdated Show resolved Hide resolved
charts/datadog/values.yaml Outdated Show resolved Hide resolved
charts/datadog/values.yaml Outdated Show resolved Hide resolved
charts/datadog/values.yaml Outdated Show resolved Hide resolved
@liliyadd liliyadd requested a review from a team November 2, 2023 15:44
Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, the PR looks good.

could you add a new ci values.yaml to test the new parameter here: https://github.com/DataDog/helm-charts/tree/main/charts/datadog/ci

@liliyadd liliyadd requested review from clamoriniere and a team November 13, 2023 16:27
@liliyadd
Copy link
Contributor Author

liliyadd commented Nov 15, 2023

I think the current failure in the pipeline tests are not related to the change introduced by this PR:
Error: INSTALLATION FAILED: execution error at (datadog/templates/daemonset.yaml:111:12): Container runtime support has to be enabled for container image collection to work. Please enable it using datadog.containerRuntimeSupport.enabled.

Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change added looks good.

But it is missing the part that check that the admission controller feature is enabled in the cluster-agent. (the option clusterAgent.admissionController.enabled is true by default but it can be good to verify that is was not disable on purpose by a user.)

charts/datadog/templates/NOTES.txt Outdated Show resolved Hide resolved
charts/datadog/templates/NOTES.txt Outdated Show resolved Hide resolved
@clamoriniere clamoriniere self-requested a review November 15, 2023 18:41
@liliyadd
Copy link
Contributor Author

I didn't realize all commits need to be signed 😭 I cannot merge this PR, so created #1245

@liliyadd
Copy link
Contributor Author

Closing as this logic has been merged in #1245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants