-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APMON-284] Add support of APM Single Step Instrumentation in helm #1211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall, the PR looks good.
could you add a new ci values.yaml to test the new parameter here: https://github.com/DataDog/helm-charts/tree/main/charts/datadog/ci
I think the current failure in the pipeline tests are not related to the change introduced by this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change added looks good.
But it is missing the part that check that the admission controller feature is enabled in the cluster-agent. (the option clusterAgent.admissionController.enabled
is true
by default but it can be good to verify that is was not disable on purpose by a user.)
I didn't realize all commits need to be signed 😭 I cannot merge this PR, so created #1245 |
Closing as this logic has been merged in #1245 |
What this PR does / why we need it:
Starting from release 7.49.x, cluster agent supports Single Step Instrumentation. This change allows configuring Single Step Instrumentation during agent installation with Helm.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md
make update-test-baselines
)