Update datadog-operator chart to v1.4.1 and datadog-crds chart to v1.3.0 #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanny-jiang
force-pushed
the
fanny/CECO-838/update-operator-chart
branch
from
08fbbaf
to
dd8de8b
Compare
fanny-jiang
commented
Jan 4, 2024
Comment on lines
+5
to
+6
| digest: sha256:86af5339c70e484401b7d340b2380802c93f946ceb0441d7348f74811917be8b | ||
| generated: "2024-01-04T12:16:01.40644-05:00" |
There was a problem hiding this comment.
This got updated because I updated and re-built the operator chart dependencies. Should I copy the sha256 and timestamp from the datadog-operator-v1.4.1. tag? I'm concerned this change might trigger a conflicting tag or override the datadog-operator-v1.4.1 chart tag.
There was a problem hiding this comment.
In the add-on environment chart dependencies should be packaged together with the wrapper, they aren't pulled from the Helm repo. So this should be fine. As long as chart can be rendered and installed properly we should be good.
levan-m
reviewed
Jan 5, 2024
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v2 | |||
| name: datadog-operator | |||
| version: 1.0.5 | |||
| appVersion: 1.0.3 | |||
| version: 1.4.1 | |||
There was a problem hiding this comment.
This needs to be update in the operator-eks-addon chart and it's version bumped.
levan-m
force-pushed
the
fanny/CECO-838/update-operator-chart
branch
from
12fb2ae
to
7f26cb8
Compare
…gs, and regenerate wrapper baseline
levan-m
force-pushed
the
fanny/CECO-838/update-operator-chart
branch
from
ca5aa7b
to
dfad543
Compare
chart to v0.6.1
levan-m
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update datadog-crds chart to v1.4.1 and datadog-operator chart to v1.3.0 for new operator-eks-addon wrapper chart release.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.mdmake update-test-baselines)