Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog-crds] update CRDs following datadog operator 1.8.0 release #1491

Merged
merged 4 commits into from
Aug 16, 2024
Merged

[datadog-crds] update CRDs following datadog operator 1.8.0 release #1491

merged 4 commits into from
Aug 16, 2024

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Aug 15, 2024

What this PR does / why we need it:

CRD updates for Operator 1.8.0 release.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • [] For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

@levan-m levan-m added the chart/datadog-crds This issue or pull request is related to the datadog-crds chart label Aug 15, 2024
@levan-m levan-m requested review from a team as code owners August 15, 2024 19:10
celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
charts/datadog-crds/templates/datadoghq.com_datadogagents_v1.yaml
Comment on lines -9415 to -9420
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this needs to be kept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These got removed during controller-gen upgrade here DataDog/datadog-operator#1247.

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
charts/datadog-crds/templates/datadoghq.com_datadogagents_v1beta1.yaml
@@ -9397,6 +6558,10 @@ spec:
type: object
type: object
type: object
type: object
version: v2alpha1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this because of the removal of name: v2alpha1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the 'before' version it's on the line 28, set to version: v1alpha1, this change happened when we stopped generating v1alpha1 CRD here DataDog/datadog-operator#1242.

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
charts/datadog-crds/templates/datadoghq.com_datadogmetrics_v1.yaml
Comment on lines -120 to -125
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be kept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded above

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
charts/datadog-crds/templates/datadoghq.com_datadogmonitors_v1.yaml
Comment on lines -297 to -302
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same :)

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
charts/datadog-crds/templates/datadoghq.com_datadogslos_v1.yaml
Comment on lines -199 to -204
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same.. what I read when I spotted it was that this is added by API server anyway.

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
crds/datadoghq.com_datadogagentprofiles.yaml
Comment on lines -179 to -184
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
crds/datadoghq.com_datadogagents.yaml Outdated
Comment on lines 9389 to 9394
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
crds/datadoghq.com_datadogmetrics.yaml Outdated
Comment on lines 114 to 119
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
crds/datadoghq.com_datadogmonitors.yaml Outdated
Comment on lines 291 to 296
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
crds/datadoghq.com_datadogslos.yaml Outdated
Comment on lines 193 to 198
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
charts/datadog-crds/templates/datadoghq.com_datadogagentprofiles_v1.yaml
Comment on lines -185 to -190
status:
acceptedNames:
kind: ""
plural: ""
conditions: []
storedVersions: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

celenechang
celenechang reviewed Aug 16, 2024
View reviewed changes
charts/datadog-crds/templates/datadoghq.com_datadogagentprofiles_v1beta1.yaml
@@ -58,9 +58,107 @@ spec:
containers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need to keep the v1beta1 templates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some changes in 1.8.0 so I did update and changed the script to stop updating it in the future.

@levan-m levan-m enabled auto-merge (squash) August 16, 2024 18:32
@levan-m levan-m merged commit de8f82c into main Aug 16, 2024
4 checks passed
@levan-m levan-m deleted the levan-m/crd-update-1.8.0 branch August 16, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celenechang celenechang celenechang approved these changes

Assignees
No one assigned
Labels
chart/datadog-crds This issue or pull request is related to the datadog-crds chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levan-m @celenechang