Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm chart for new Go private action runner #1527

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

oliverli
Copy link
Contributor

@oliverli oliverli commented Sep 13, 2024

What this PR does / why we need it:

Releases runner v0.1.0-beta, with the necessary changes in the Helm chart for the slight differences in config.yaml

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md
  • For Datadog Operator chart or value changes update the test baselines (run: make update-test-baselines)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @oliverli and the rest of your teammates on Graphite Graphite

@oliverli oliverli force-pushed the oliver/staging-changes-for-go-private-action-runner branch from c66ed12 to b39f9ae Compare September 16, 2024 15:05
@oliverli oliverli changed the title staging changes for Go private action runner Update Helm chart for new Go private action runner Sep 16, 2024
@oliverli oliverli marked this pull request as ready for review September 16, 2024 15:14
@oliverli oliverli requested a review from a team as a code owner September 16, 2024 15:14
@ksun154
Copy link
Contributor

ksun154 commented Sep 16, 2024

can you also update the port here
https://github.com/DataDog/helm-charts/blob/main/charts/private-action-runner/examples/config.yaml

Copy link
Contributor

@irubnich irubnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left some suggestions based on my experience deploying this

charts/private-action-runner/examples/config.yaml Outdated Show resolved Hide resolved
charts/private-action-runner/examples/config.yaml Outdated Show resolved Hide resolved
@irubnich
Copy link
Contributor

just something else i noticed - Helm values are by default provided in a file named values.yaml, but we call it config.yaml.

i found this confusing because (1) it's not conventional to Helm, and (2) it could cause ambiguity with our config.yaml file which isn't really applicable in the Helm case.

so i suggest renaming config.yaml to values.yaml

@oliverli oliverli requested a review from a team as a code owner September 18, 2024 17:58
Copy link
Contributor

@irubnich irubnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you!

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @oliverli and the rest of your teammates on Graphite Graphite

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @oliverli and the rest of your teammates on Graphite Graphite

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @oliverli and the rest of your teammates on Graphite Graphite

@oliverli
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 18, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 40m.

Use /merge -c to cancel this operation!

@oliverli
Copy link
Contributor Author

/remove

@dd-devflow
Copy link

dd-devflow bot commented Sep 18, 2024

🚂 Devflow: /remove

@dd-devflow
Copy link

dd-devflow bot commented Sep 18, 2024

⚠️ MergeQueue: This merge request build was cancelled

This merge request build was cancelled

If you need support, contact us on Slack #devflow!

@oliverli oliverli merged commit 05fd80b into main Sep 18, 2024
18 of 19 checks passed
@oliverli oliverli deleted the oliver/staging-changes-for-go-private-action-runner branch September 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants