-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Helm chart for new Go private action runner #1527
Update Helm chart for new Go private action runner #1527
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c66ed12
to
b39f9ae
Compare
can you also update the port here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i left some suggestions based on my experience deploying this
just something else i noticed - Helm values are by default provided in a file named i found this confusing because (1) it's not conventional to Helm, and (2) it could cause ambiguity with our so i suggest renaming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice thank you!
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
/remove |
🚂 Devflow: |
This merge request build was cancelled If you need support, contact us on Slack #devflow! |
What this PR does / why we need it:
Releases runner
v0.1.0-beta
, with the necessary changes in the Helm chart for the slight differences inconfig.yaml
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)N/A
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md
make update-test-baselines
)