Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autopilot error message #1558

Closed
wants to merge 2 commits into from

Conversation

aquiladayc
Copy link
Contributor

What this PR does / why we need it:

Currently, error message is

Error: execution error at (datadog/templates/NOTES.txt:341:4): On GKE Autopilot environments, System Probe is not supported. The option 'datadog.securityAgent.runtime.enabled' must be set 'false'

but system probe can be enabled by other options that are not mentioned in error message. This PR adds those options.

Currently, error message is
```
Error: execution error at (datadog/templates/NOTES.txt:341:4): On GKE Autopilot environments, System Probe is not supported. The option 'datadog.securityAgent.runtime.enabled' must be set 'false'
```
but system probe can be enabled by other options that are not mentioned in error message.
@aquiladayc aquiladayc requested a review from a team as a code owner October 15, 2024 05:15
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Oct 15, 2024
@aquiladayc aquiladayc changed the title Aquiladayc/gke autopilot error message autopilot error message Oct 15, 2024
@aquiladayc aquiladayc changed the title autopilot error message Fix autopilot error message Oct 15, 2024
Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aquiladayc

thanks for this contribution.

the change logs good, however the chart version in chart.yaml has not been updated and the script to update the README.md has not been executed too.

please check the instruction in the PR description 🙇

@aquiladayc
Copy link
Contributor Author

Thanks for review @clamoriniere
Recreated a PR, can you have a look please? I think I followed instructions but let me know if i missed anything. Thanks!
#1562

@aquiladayc aquiladayc closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants