Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS dependency build #16615

Merged
merged 18 commits into from
Jan 26, 2024
Merged

Add MacOS dependency build #16615

merged 18 commits into from
Jan 26, 2024

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Jan 15, 2024

What does this PR do?

Implements the build of dependency wheels for MacOS.

Motivation

APL-2768

Additional Notes

There's potential for caching of the libraries we build to speed up the build time, but can be left for later.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Base automatically changed from ofek/builders to master January 16, 2024 17:22
@alopezz alopezz marked this pull request as ready for review January 17, 2024 10:36
@alopezz alopezz requested a review from a team as a code owner January 17, 2024 10:36
@alopezz alopezz force-pushed the alopez/builders-macos branch 13 times, most recently from 4a387de to 2f19e93 Compare January 17, 2024 16:48
@alopezz alopezz marked this pull request as draft January 17, 2024 17:14
@alopezz alopezz force-pushed the alopez/builders-macos branch 8 times, most recently from dd2af07 to b2eada5 Compare January 18, 2024 11:53
@alopezz alopezz force-pushed the alopez/builders-macos branch 2 times, most recently from 63fbd2f to 891671a Compare January 25, 2024 15:50
@alopezz alopezz force-pushed the alopez/builders-macos branch 3 times, most recently from a193dbc to 520561b Compare January 25, 2024 16:28
@alopezz alopezz marked this pull request as ready for review January 25, 2024 17:03

- name: Set up Python
env:
# Despite the name, this is built for the macOS 11 SDK on arm64 and 10.9+ on intel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this running?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the question.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in how is the binary running successfully if it was built for a different architecture?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Universal2 binaries are compatible with both Intel and arm64 (https://en.wikipedia.org/wiki/Universal_binary), the comment means to explain that the 11 in the package name refers to the SDK version used for the arm64 variant, whereas for intel (which is the one we're actually using in the build) it is built with 10.9, meaning we should be able to build wheels with support for MacOS versions 10.9+.

.builders/scripts/build_wheels.py Outdated Show resolved Hide resolved
.builders/images/linux-x86_64/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misclick

@alopezz alopezz merged commit b7d8f3e into master Jan 26, 2024
45 checks passed
@alopezz alopezz deleted the alopez/builders-macos branch January 26, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants