-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added vonage integration without assets #18903
Open
deepakg-sacumen
wants to merge
9
commits into
DataDog:master
Choose a base branch
from
deepakg-sacumen:vonage_integration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
added vonage integration without assets #18903
deepakg-sacumen
wants to merge
9
commits into
DataDog:master
from
deepakg-sacumen:vonage_integration
+92
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
documentation
changelog/no-changelog
qa/skip-qa
Automatically skip this PR for the next QA
team/agent-integrations
team/documentation
labels
Oct 23, 2024
rtrieu
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback to comply with our style guide. The integration URL appears to be missing but it may not be ready yet.
datadog-assets
bot
added
docs/requested-changes
and removed
docs/review-requested
labels
Oct 23, 2024
rtrieu
previously approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/no-changelog
docs/requested-changes
documentation
ecosystems/review-requested
product/review-requested
qa/skip-qa
Automatically skip this PR for the next QA
team/agent-integrations
team/documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR includes skeleton of Vonage integration without any assets like dashboards, image, README content, etc.
Motivation
This is beta release of crawler integration and is intended for internal testing before going live. We will raise separate PR with assets and all necessary information once this PR has been merged.
Additional Notes
Only crawler-based integration related changes are included in this PR.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged