Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.59.x] Add option to disable stage metrics and stage_id tags #18909

Closed

Conversation

datadog-agent-integrations-bot[bot]
Copy link
Contributor

Backport 9d54b18 from #18791.


What does this PR do?

This adds an option to disable stage_id from being attached to spark.job metrics and adds an option to disable the collection of stage metrics as a whole.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

* Add option to disable stage metrics and stage_id tags

* Add tests

* Lint

* Add changelog

* Make changelog one single line

(cherry picked from commit 9d54b18)
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (7.59.x@cff91ad). Learn more about missing BASE report.

Additional details and impacted files
Flag Coverage Δ
spark 93.47% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant