Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plaid integration #18917

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

deepakg-sacumen
Copy link

What does this PR do?

PR includes skeleton of Vonage integration without any assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live. We will raise separate PR with assets and all necessary information once this PR has been merged.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, if this is not intended to be publicly available, please ensure display_on_public_website is set to false in the manifest.

"manifest_version": "2.0.0",
"app_uuid": "d5c95215-bc13-4925-941b-ede8459d9005",
"app_id": "plaid",
"display_on_public_website": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"display_on_public_website": true,
"display_on_public_website": false,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants