-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CONTP-382] Updating dashboards to use grouping and validation widget #18919
base: master
Are you sure you want to change the base?
Conversation
"type": "timeseries", | ||
"requests": [ | ||
"title": "Cluster Check Runners", | ||
"background_color": "white", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"definition": { | ||
"type": "note", | ||
"content": "Overview", | ||
"content": "Cluster Checks", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the reason this is not a group because you can't have widget groups inside groups? would have been nice to have Overview
look the same as Cluster Checks
as before
"value": 72 | ||
"id": 7089651226858956, | ||
"definition": { | ||
"title": "Successful validation attempts per minute by type", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is there a reason these graphs are named differently i.e. Successful ... per minute by type
vs Failed ... by type per minute
?
same applies for the mutation attempts
graphs
What does this PR do?
Updates the Datadog Cluster Agent - Overview dashboard.
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is mergedNote: the two added widgets were at the bottom called Successful validation_attempts and Failed validation_attempts