refactor: remove global variables for all commands #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, this makes a lot of sense! Do you know if we have the same problem for other commands? If yes it would make sense to fix it for others as well |
Yes, I see this in other commands. I can refactor them as well |
aymene01
changed the title
|
Accidentally closed the PR with a misclick 😑, done for all commands you can have a look and give me your feedback :) |
christophetd
reviewed
Oct 2, 2024
| return errors.New("pass the ID of the technique to clean up, or --all") | ||
| } | ||
| return nil | ||
| if len(args) == 0 && !flagCleanupAll { |
There was a problem hiding this comment.
should this be flagCleanupAll like before?
christophetd
reviewed
Oct 2, 2024
| } | ||
|
|
||
| // Ensure the technique IDs are valid | ||
| _, err := resolveTechniques(args) | ||
| if len(args) > 0 { |
There was a problem hiding this comment.
do we need this check? (it wasn'tthere before)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the detonate_cmd.go file by removing the use of global variables, which improves code maintainability and readability.
Motivation
This is my first contribution to a Datadog repository, and I'm eager to get started on security in the cloud and security in general.
Checklist