[WIP] AZINTS-2487 Metric filtering updates to terraform #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishwarya-ddog
changed the title
domalessi
approved these changes
Jul 8, 2024
| @@ -45,6 +48,7 @@ resource "datadog_integration_azure" "sandbox" { | |||
| Note: This requires `resource_collection_enabled` to be set to true. Defaults to `false`. | |||
| - `custom_metrics_enabled` (Boolean) Enable custom metrics for your organization. Defaults to `false`. | |||
| - `host_filters` (String) String of host tag(s) (in the form `key:value,key:value`) defines a filter that Datadog will use when collecting metrics from Azure. Limit the Azure instances that are pulled into Datadog by using tags. Only hosts that match one of the defined tags are imported into Datadog. e.x. `env:production,deploymentgroup:red` Defaults to `""`. | |||
| - `metrics_config` (String) A JSON object representing the metrics configuration. It must include the excluded_resource_providers attribute which is a list of Microsoft Resource Provider name strings for which metrics collection is to be disabled. If excluded_resource_providers is an empty list, it means that all Microsoft Resource Providers are enabled for metrics filtering. Defaults to `"{"excluded_resource_providers":[]}"`. | |||
There was a problem hiding this comment.
Suggested change
| - `metrics_config` (String) A JSON object representing the metrics configuration. It must include the excluded_resource_providers attribute which is a list of Microsoft Resource Provider name strings for which metrics collection is to be disabled. If excluded_resource_providers is an empty list, it means that all Microsoft Resource Providers are enabled for metrics filtering. Defaults to `"{"excluded_resource_providers":[]}"`. | |
| - `metrics_config` (String) A JSON object representing the metrics configuration. It must include the `excluded_resource_providers` attribute, a list of Microsoft Resource Provider name strings for which metrics collection will be disabled. If `excluded_resource_providers` is an empty list, all Microsoft Resource Providers are enabled for metrics filtering. Defaults to `"{"excluded_resource_providers":[]}"`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update terraform templates to help update and get metric filters - ie allow users to enable and disable Microsoft resource providers from metric collection.
metrics_config is a json which has one attribute : excluded_resource_providers which takes in a list of Microsoft resource provider name strings.
RFC
https://docs.google.com/document/d/10sDJY0CWCzlAHCvV11DCkmWftTqz2qaxUvI_VYXHmcE/edit?usp=sharing
Who will it impact?
Any customer that uses the api and the webflow to create an app registration as long as the FF is turned on for them
Motivation
Help customers control costs by letting them filter resource providers from collecting metrics