-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTEL-1982] Support OTEL agent docker deployement #968
Conversation
73caf2f
to
857574c
Compare
… kfairise/otel-agent-kubernetes
if e.PipelineID() != "" && e.CommitSHA() != "" && imageTag == "" { | ||
tag := fmt.Sprintf("%s-%s", e.PipelineID(), e.CommitSHA()) | ||
if otel { | ||
tag = fmt.Sprintf("%s-7-ot-beta", tag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this beta suffix is subject to change and will eventually be removed or updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. We should be able to modify it easily when needed. Do not think it is worth to do more here as I think the tag will not change every two days once this is no longer in beta
Co-authored-by: Stanley Liu <[email protected]>
Co-authored-by: Stanley Liu <[email protected]>
Co-authored-by: Stanley Liu <[email protected]>
Co-authored-by: Stanley Liu <[email protected]>
… kfairise/otel-agent-kubernetes
What does this PR do?
Add options to be able to deploy the otel-agent in Kubernetes environments
To make it easier it also slightly refactor the way we know which image we should fetch when running in the CI
Which scenarios this will impact?
Motivation
Additional Notes
Needs DataDog/helm-charts#1429