[OTEL-1982] Support OTEL agent docker deployement #968
+72
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinFairise2
force-pushed
the
kfairise/otel-agent-kubernetes
branch
from
73caf2f
to
857574c
Compare
… kfairise/otel-agent-kubernetes
liustanley
reviewed
Jul 25, 2024
| if e.PipelineID() != "" && e.CommitSHA() != "" && imageTag == "" { | ||
| tag := fmt.Sprintf("%s-%s", e.PipelineID(), e.CommitSHA()) | ||
| if otel { | ||
| tag = fmt.Sprintf("%s-7-ot-beta", tag) |
There was a problem hiding this comment.
FYI this beta suffix is subject to change and will eventually be removed or updated
There was a problem hiding this comment.
ACK. We should be able to modify it easily when needed. Do not think it is worth to do more here as I think the tag will not change every two days once this is no longer in beta
Co-authored-by: Stanley Liu <[email protected]>
Co-authored-by: Stanley Liu <[email protected]>
Co-authored-by: Stanley Liu <[email protected]>
Co-authored-by: Stanley Liu <[email protected]>
… kfairise/otel-agent-kubernetes
pducolin
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add options to be able to deploy the otel-agent in Kubernetes environments
To make it easier it also slightly refactor the way we know which image we should fetch when running in the CI
Which scenarios this will impact?
Motivation
Additional Notes
Needs DataDog/helm-charts#1429