Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate canceling script #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leskiw77
Copy link

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #173 into master will increase coverage by 0.82%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   59.15%   59.97%   +0.82%     
==========================================
  Files          13       13              
  Lines         923      942      +19     
  Branches      150      150              
==========================================
+ Hits          546      565      +19     
  Misses        315      315              
  Partials       62       62
Impacted Files Coverage Δ
mcpartools/generator.py 64.32% <100%> (+1.07%) ⬆️
mcpartools/scheduler/slurm.py 100% <100%> (ø) ⬆️
mcpartools/scheduler/torque.py 100% <100%> (ø) ⬆️
mcpartools/scheduler/base.py 87.87% <100%> (+2.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e393eea...23c38cd. Read the comment docs.

def write_kill_script(self, script_path):
fd = open(script_path, 'w')
fd.write(self.submit_kill_body())
fd.close()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with open(script_path, 'w') as f:
    f.write(self.submit_kill_body())

?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work for python 2.6 ?

@reviewpad reviewpad bot mentioned this pull request Mar 28, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants