status script generation #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 59.15% 61.01% +1.85%
==========================================
Files 13 13
Lines 923 967 +44
Branches 150 150
==========================================
+ Hits 546 590 +44
Misses 315 315
Partials 62 62
Continue to review full report at Codecov.
|
grzanka
reviewed
Dec 10, 2018
mcpartools/scheduler/data/status.sh
Outdated
|
|
||
| if [[ $CMD_STATUS -eq 0 && $SAVE_TO_FILE_FLAG = true ]] | ||
| then | ||
| echo "Status successfully saved to file." |
There was a problem hiding this comment.
Can you print on the screen to which file the status was saved ?
grzanka
reviewed
Dec 10, 2018
| cat $ERR >> "$LOGFILE" | ||
| fi | ||
|
|
||
| MERGE_LOGS_CMD="sbatch --dependency=afterany:$LAST_JOB_ID --output='{log_dir:s}/output_%j_merge_logs.log' --error='{log_dir:s}/error_%j_merge_logs.log' --parsable {main_dir:s}/workspace/merge_logs.sh -s > $OUT 2> $ERR" |
There was a problem hiding this comment.
I do not see much sense in submitting log merging as separate job. It should either be simply executed by user in the same session as status.sh script is being called or added at the end of collect script.
I suspect that:
- in 99% cases user would simply call
status.shwithout-soption and will never take look on the logs, while merge logs will always be called, adding unnecessary jobs to the queue. - execution time is so short of "merge logs" that it probably will execute faster than the time needed to enter running state
added 2 commits
December 10, 2018 22:56
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#87