Release 1.0.0 #40
Merged
Release 1.0.0 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise the API breaks
…solution, image position.
…'Nothing You Could Do'
Merge branch 'develop' of https://github.com/theamarks/scythe into develop # Conflicts: # logo/Scythe_logo.R # man/figures/logo.png
Add export documentation to xdd search function & reformat code
regetz
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Nice milestone @jeanetteclark! I made a handful of suggested changes, but they're pretty much all refactoring in one way or another -- nothing that substantively changes how the searches are done or what gets output in the end. Happy to talk more about any of them, but otherwise you can make the call about which (if any) you want to incorporate.
regetz
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Looks good to me -- thanks @jeanetteclark for taking care of everything here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major release which improves testing and adds the XDD source. It also rewrites the plos citation function, since
rploswas deprecated and removed from CRAN.