Add the ability to get historical data using a specified date range #144
+434
−4,174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liardoecp
force-pushed
the
143-Add-the-ability-to-get-historical-data-using-a-specified-date-range
branch
from
9573492
to
dd63b6a
Compare
Pull Request Test Coverage Report for Build 11488771336Details
💛 - Coveralls |
liardoecp
commented
Oct 24, 2024
Comment on lines
+15
to
+19
| const response = await fetch(buildUrl(params), { | ||
| headers: new Headers({ | ||
| 'upgrade-insecure-requests': '1', | ||
| }), | ||
| }); |
There was a problem hiding this comment.
Maybe Puppeteer should be used here to call investing.com. I used fetch at the end if #141 PR will be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143