Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: cumulative worker id without entry server #255

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

YuriCat
Copy link
Contributor

@YuriCat YuriCat commented Jan 26, 2022

Combining #245 and #246, it seems natural to implement it like this.

@ikki407
Copy link
Member

ikki407 commented Jan 26, 2022

Yeah, it's natural. I think this combined version is better than #245 and #246.

Comment on lines +172 to +174
if gather_id == 0: # call once at every machine
print(args)
prepare_env(args['env'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe...? I can't think of any problems though...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to remove prepare_env() ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants