Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapter for daily fees and daily revenue data, for assetchain blockchain #2029

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Adapter for daily fees and daily revenue data, for assetchain blockchain #2029

merged 4 commits into from
Oct 25, 2024

Conversation

theiceeman
Copy link
Contributor

No description provided.

@llamatester
Copy link

The assetchain.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees assetchain.ts

🦙 Running ASSETCHAIN.TS adapter 🦙
---------------------------------------------------
Start Date:	Mon, 21 Oct 2024 02:33:20 GMT
End Date:	Tue, 22 Oct 2024 02:33:20 GMT
---------------------------------------------------

ASSETCHAIN 👇
Backfill start time: 29/8/2020
NO METHODOLOGY SPECIFIED
Daily fees: 0
Daily revenue: 0
End timestamp: 1729564399 (2024-10-22T02:33:19.000Z)

@theiceeman
Copy link
Contributor Author

Hello @0xngmi
can you review this pr pls
Or is there something still missing on our end.
Thanks

@g1nt0ki
Copy link
Member

g1nt0ki commented Oct 24, 2024

@theiceeman sorry for the delay, reviewing it now

g1nt0ki
g1nt0ki reviewed Oct 24, 2024
View reviewed changes
.gitignore Outdated
.idea
yarn.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this

@llamatester
Copy link

The assetchain.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees assetchain.ts

🦙 Running ASSETCHAIN.TS adapter 🦙
---------------------------------------------------
Start Date:	Wed, 23 Oct 2024 05:05:30 GMT
End Date:	Thu, 24 Oct 2024 05:05:30 GMT
---------------------------------------------------

ASSETCHAIN 👇
Backfill start time: 29/8/2020
NO METHODOLOGY SPECIFIED
Daily fees: 0
Daily revenue: 0
End timestamp: 1729746329 (2024-10-24T05:05:29.000Z)

g1nt0ki
g1nt0ki reviewed Oct 24, 2024
View reviewed changes
fees/assetchain.ts Outdated
return epochData.reduce((acc: any, data: any) => acc + +data.epochFee, 0)
}

export async function getPrice() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR is mostly good except for this PR, I cant find the token on coingecko, is it traded in some exchange atm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is.
There is a coinmarketcap page here for the token.
https://coinmarketcap.com/currencies/xend-finance/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @g1nt0ki
does this dispell your concerns?
can we proceed with merging the pr pls
Thanks

@g1nt0ki g1nt0ki self-assigned this Oct 24, 2024
@llamatester
Copy link

The assetchain.ts adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees assetchain.ts

🦙 Running ASSETCHAIN.TS adapter 🦙
---------------------------------------------------
Start Date:	Thu, 24 Oct 2024 05:40:09 GMT
End Date:	Fri, 25 Oct 2024 05:40:09 GMT
---------------------------------------------------

ASSETCHAIN 👇
Backfill start time: 29/8/2020
NO METHODOLOGY SPECIFIED
Daily fees: 0
Daily revenue: 0
End timestamp: 1729834808 (2024-10-25T05:40:08.000Z)

@g1nt0ki g1nt0ki merged commit ac5499c into DefiLlama:master Oct 25, 2024
2 checks passed
@dtmkeng
Copy link
Contributor

dtmkeng commented Oct 26, 2024

@theiceeman i try refill data but it still 0 every day is it correct ?

@theiceeman
Copy link
Contributor Author

Let me confirm this pls
Thank you

@theiceeman
Copy link
Contributor Author

Hello @dtmkeng
I reviewed this, and there was an issue with the value.
My update still returns zero, but thats because the fees generated currently are very small.
Less than 0.

It seems DefiLlama rounds values like that to 0.
Pls merge the update i made below.
Thanks.

#2061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g1nt0ki g1nt0ki g1nt0ki left review comments

Assignees

@g1nt0ki g1nt0ki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theiceeman @llamatester @g1nt0ki @dtmkeng