Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bulbaswap volume add fees #2072

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add bulbaswap volume add fees #2072

wants to merge 2 commits into from
+114 −1

Conversation

madwiki
Copy link

@madwiki madwiki commented Nov 5, 2024

No description provided.

@llamatester
Copy link

The bulbaswap adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts aggregators bulbaswap

🦙 Running BULBASWAP adapter 🦙
---------------------------------------------------
Start Date:	Mon, 04 Nov 2024 00:00:00 GMT
End Date:	Tue, 05 Nov 2024 00:00:00 GMT
---------------------------------------------------

MORPH 👇
Backfill start time: 1/8/2023
NO METHODOLOGY SPECIFIED
End timestamp: 1730764800 (2024-11-05T00:00:00.000Z)
Total volume: 482.72 k
Daily volume: 3.31 k
Daily fees: 12
Total fees: 1.65 k

@llamatester
Copy link

The bulbaswap adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts aggregators bulbaswap

🦙 Running BULBASWAP adapter 🦙
---------------------------------------------------
Start Date:	Mon, 04 Nov 2024 00:00:00 GMT
End Date:	Tue, 05 Nov 2024 00:00:00 GMT
---------------------------------------------------

MORPH 👇
Backfill start time: 22/10/2024
NO METHODOLOGY SPECIFIED
End timestamp: 1730764800 (2024-11-05T00:00:00.000Z)
Total volume: 482.73 k
Daily volume: 3.32 k
Daily fees: 12
Total fees: 1.65 k

@dtmkeng
Copy link
Contributor

dtmkeng commented Nov 6, 2024

is it dexs volume not agg ?

dtmkeng
dtmkeng requested changes Nov 6, 2024
View reviewed changes
aggregators/bulbaswap/index.ts
totalFeesUSD
txCount
}
uniswapDayDatas(first: 1, orderBy: date, orderDirection: desc) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use query by Id, because if data not up to date will collect incorrect data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtmkeng dtmkeng dtmkeng requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madwiki @llamatester @dtmkeng