refactor: refactor use progress hook
#241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make handle as const there is no need to state add interface progresshook verification xhr.lengthComputable valide to calclul new progress create handleUploadProgress in use effect to create it only when we needed and Encapsulated it verify new progress in the handleuploadprogress to lake it clean and to avoid extra effect Cleanup event listener on unmount or when files change
add JSDoc . return `true` immediately if any file or criter to match for improving performance. accepted file types to lowercase to be sure about case-insensitive Removed unnecessary regex and replaced it with simple method Encapsulated logic in Array.some()
|
@Iyadchafroud please fix prettier by running : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make handle as const there is no need to state
add interface progresshook
verification xhr.lengthComputable valide to calclul new progress create handleUploadProgress in use effect to create it only when we needed and Encapsulated it verify new progress in the handleuploadprogress to lake it clean and to avoid extra effect Cleanup event listener on unmount or when files change