Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http basic auth for X-Pack plugin #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tanhaipeng
Copy link

@tanhaipeng tanhaipeng commented Oct 12, 2018

fix #29

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 87.126% when pulling 692b5fb on tanhaipeng:master into 490f6b2 on DhavalKapil:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 87.126% when pulling 692b5fb on tanhaipeng:master into 490f6b2 on DhavalKapil:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 87.126% when pulling 692b5fb on tanhaipeng:master into 490f6b2 on DhavalKapil:master.

@tanhaipeng
Copy link
Author

tanhaipeng commented Oct 12, 2018

Check how your Lua installation was built. lua_objlen is only available if you compile Lua with certain compatibility flags: https://www.lua.org/source/5.3/luaconf.h.html
It was renamed to lua_rawlen in 5.2.
You need to rebuild with -DLUA_COMPAT_5_1

lua 5.2 CI run failed

@neilcook
Copy link
Collaborator

neilcook commented Nov 2, 2018

I'll look at the cjson issue separately, it's a pita TBH. I'll have to build lua manually in travis rather than use the built-in lua.

Check how your Lua installation was built. lua_objlen is only available if you compile Lua with certain compatibility flags: https://www.lua.org/source/5.3/luaconf.h.html
It was renamed to lua_rawlen in 5.2.
You need to rebuild with -DLUA_COMPAT_5_1

lua 5.2 CI run failed

@neilcook
Copy link
Collaborator

neilcook commented Nov 2, 2018

If you can add some tests for the authentication code I'd be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user/password for elastic 5.5.1 X-Pack
3 participants