-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command Migration: ('GEOADD', 'GEODIST') #1033
Comments
Hi @AshwinKul28 , Can I Pick this ? |
Thanks @YuvrajGosain go for it! 🚀 |
HI @YuvrajGosain, I hope you are doing well. Do you happen to have any updates on this? If you've any doubts please let us know on the discord. |
Hi @AshwinKul28 , was a bit occupied in some other things , but will be trying to raise the PR by next 2-3 days. |
Hey @YuvrajGosain hope you are doing well, can you please update on the current progress of the task? If you have any blockers feel free to discuss here or on the discord. |
Hi @AshwinKul28 , will raise the PR by this weekend. |
Hey @YuvrajGosain whts the status |
Hi @mohit-nagaraj , I am just left with integration tests , which i'll be completing today |
Hi @AshwinKul28 / @soumya-codes can you please help review the PR - #1185 |
This issue tracks the migration of the mentioned commands - ('GEOADD', 'GEODIST') to make them compatible across the three protocols supported by the Dice database: RESP, HTTP, and WebSocket.
DiceDB now supports more than one protocols (Resp/http/websocket). We don't want eval operation of each command to be strictly bound with any of the protocols. Currently eval function return statements of each command is bounded to the RESP protocol.
The migration is required because:
The goal is to make the command logic protocol-independent, allowing all three protocols to call the same core functionality seamlessly.
Requirements
[Command Name]
to be generic.Migration Steps
Analyze Current Implementation
Refactor Return Logic
evalXXX(args []string, store *dstore.Store) *EvalResponse
under the file/internal/eval/store_eval.go
/errors/migrated_errors.go
file/internal/clientio/resp.go
file as RespType variablesCommand/Worker specific Changes
IsMigrated
flag to true in the commands information under/internal/eval/commands.go
file.NewEval
parameter in the same command structure./internal/eval/eval.go
file./internal/worker/CommandsMeta
map and make it's type asSingleShard
Update Unit Tests
Integration Tests
Checklist
Additional Notes
If there are any questions or concerns about this migration, please mention them here.
Related Issues/PRs
The text was updated successfully, but these errors were encountered: