Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1033 Migrating GEOADD and GEODIST command #1185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#1033 Migrating GEOADD and GEODIST command #1185

wants to merge 1 commit into from

Conversation

YuvrajGosain
Copy link

@YuvrajGosain YuvrajGosain commented Oct 22, 2024 •
edited by AshwinKul28
Loading

Issue: #1033

  • Migrated the evalXXX function with the latest definition
  • Update or add unit tests for the new implementation.
  • All unit tests pass successfully.
  • Ensure all integration tests pass successfully.
  • Ensure integration tests are added for the migrated command on multi-threaded resp server.
  • Move Integration tests for the respective commands under the RESP integration tests directory from Async directory
  • Please validate that the documentation for the respective commands is up to date. If not then consider adding them.

@YuvrajGosain YuvrajGosain changed the title Migrating GEOADD and GEODIST command #1033 Migrating GEOADD and GEODIST command Oct 22, 2024
@YuvrajGosain YuvrajGosain mentioned this pull request Oct 22, 2024
Open
4 tasks
@AshwinKul28 AshwinKul28 added the migration -- command Migrates current eval to a refactored eval for all protocols functionality label Oct 22, 2024
@AshwinKul28 AshwinKul28 linked an issue Oct 24, 2024 that may be closed by this pull request
Command Migration: ('GEOADD', 'GEODIST') #1033
Open
4 tasks
lucifercr07
lucifercr07 requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@lucifercr07 lucifercr07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuvrajGosain can follow sample doc template and update for these commands accordingly it'd be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucifercr07 lucifercr07 lucifercr07 requested changes

@soumya-codes soumya-codes Awaiting requested review from soumya-codes

Assignees
No one assigned
Labels
migration -- command Migrates current eval to a refactored eval for all protocols functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command Migration: ('GEOADD', 'GEODIST')
3 participants
@YuvrajGosain @lucifercr07 @AshwinKul28