-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed scope of CmdWatchSubscriptionChan to local #1169
base: master
Are you sure you want to change the base?
Conversation
also, i think my linter might be misconfigured or something, the diff shows extra lines touched. :( |
Looks like you may have messed up the merge with master. Usually, you want to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution @KanniShashankh! The changes look good overall, have left a few minor comments.
…nto issue-1000
it's not global anymore, this might be a noobish implemention tho, i'm open for advice on how to implement it in a better way. Thanks!
Fixes #1000
CmdWatchSubscriptionChan shouldn't be a global variable