Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed scope of CmdWatchSubscriptionChan to local #1169

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

KanniShashankh
Copy link

it's not global anymore, this might be a noobish implemention tho, i'm open for advice on how to implement it in a better way. Thanks!

Fixes #1000
CmdWatchSubscriptionChan shouldn't be a global variable

@KanniShashankh
Copy link
Author

also, i think my linter might be misconfigured or something, the diff shows extra lines touched. :(

@KanniShashankh KanniShashankh marked this pull request as draft October 21, 2024 17:54
@KanniShashankh
Copy link
Author

KanniShashankh commented Oct 21, 2024

am i missing something here? i'll fix the linter ci run fail but for the integration tests. it fails for even the base branch? is there some config that i'm missing?
Screenshot 2024-10-21 at 11 25 27 PM

This PR does pass getwatch_test.go and zrangewatch_test.go tests.

@KanniShashankh KanniShashankh marked this pull request as ready for review October 21, 2024 18:00
@JyotinderSingh
Copy link
Collaborator

Looks like you may have messed up the merge with master. Usually, you want to:

  1. update your local master with the upstream git checkout master && git pull upstream
  2. checkout your feature branch `git checkout
  3. merge with master git merge master
  4. push git push

Copy link
Collaborator

@JyotinderSingh JyotinderSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @KanniShashankh! The changes look good overall, have left a few minor comments.

integration_tests/commands/resp/setup.go Outdated Show resolved Hide resolved
internal/server/httpServer.go Outdated Show resolved Hide resolved
internal/server/server.go Outdated Show resolved Hide resolved
internal/server/websocketServer.go Outdated Show resolved Hide resolved
internal/watchmanager/watch_manager.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CmdWatchSubscriptionChan shouldn't be a global variable
5 participants