Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#800 Smember DOCS Consistency #1208

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

vanshavenger
Copy link
Contributor

@apoorvyadav1111 @JyotinderSingh Few pointers that need to be addressed.
Alternate Commands such as
SSCAN but right now it is not not in DICE-DB should i remove all of its Reference in the DOC for now?

Screenshot 2024-10-27 at 9 21 55 PM Screenshot 2024-10-27 at 9 21 51 PM Screenshot 2024-10-27 at 9 21 40 PM Screenshot 2024-10-27 at 9 21 34 PM

@vanshavenger
Copy link
Contributor Author

Closes #800
cc @apoorvyadav1111

@apoorvyadav1111
Copy link
Contributor

Hi @vanshavenger , these changes look good. Yes, I think we should remove all such refs. Maybe can comment them out and let it stay as to-do when SSCAN is implemented. An example :

// TODO: uncomment when SSCAN is implemented

@vanshavenger
Copy link
Contributor Author

Done @apoorvyadav1111 🚀

@apoorvyadav1111 apoorvyadav1111 changed the title Smember DOCS Consistency #800 Smember DOCS Consistency Oct 28, 2024
@apoorvyadav1111 apoorvyadav1111 merged commit 4de3038 into DiceDB:master Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants