-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement box-shadow drawing #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think your formatter is doing some weird stuff in the Cargo.toml.
I'm going to wait a day or two to merge this in case the corresponding PR on vello gets merged - and then we can just run from their main
branch instead of the actual blur branch itself.
Also, I'm not sure if they've implemented the varying-corner-radius logic yet. I believe not, and it'll require a new shader on their end to support it.
Whenever that lands, we need to update the radius here to match the actual multi-radius border logic that gets merged.
Sounds good, I've reverted the formatting on the Cargo.toml. |
Does this fix hovering the search box in the "google" example? (seach box should have shadow on hover, currently it visually disappears instead). The vello PR has now landed. We can merge this if:
|
It does 😃
Done. I've made a personal fork of vello_svg to depend on the updated Vello, not sure if thats acceptable or you'd rather update the fork at https://github.com/DioxusLabs/vello_svg |
Adds support for rendering box-shadow, using the blur-rect branch of vello.
Also updates the tailwind example to render
#cool
with a black shadow, and #cool-inset with an inset shadow, to demo support.Caveats