Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip setting default window size on mobile #129

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

matthunz
Copy link
Contributor

@matthunz matthunz commented Sep 6, 2024

Skips setting the default window size to 800x600 when compiling for mobile

Fixes #124

@matthunz matthunz added the bug Something isn't working label Sep 6, 2024
@matthunz matthunz changed the title Skip setting default window size on mobile #124 Skip setting default window size on mobile Sep 6, 2024
Copy link
Collaborator

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo (I assume) on the window size. Otherwise looks good!

Comment on lines 111 to 112
width: 800.,
height: 800.,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default window size has changed here. Can we have the height of 600 back (because some laptop only have room for 600px!)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man you're fast 😆 thanks!

@nicoburns nicoburns enabled auto-merge (squash) September 6, 2024 17:27
@nicoburns
Copy link
Collaborator

@matthunz Are you actually able to compile and run Blitz on mobile? And if so, how might I go about doing that?

@nicoburns nicoburns merged commit 9e7b743 into DioxusLabs:main Sep 6, 2024
8 checks passed
@matthunz
Copy link
Contributor Author

matthunz commented Sep 6, 2024

@matthunz Are you actually able to compile and run Blitz on mobile? And if so, how might I go about doing that?

Yeah it’s been alright to at least get it running on Android, I have a repo for testing here https://github.com/matthunz/blitz-android

As for iOS I’ve gotten dioxus-desktop to work but I haven’t tried Blitz yet 🤔 I feel like if desktop is working though Blitz there should be in the same state as Android.

Mobile does seem like we’ll need a lot of platform-specific code going forward, but I think once we have touch we can get pretty far as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile has wrong screen size since we default to (800x600)
2 participants