-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip setting default window size on mobile #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo (I assume) on the window size. Otherwise looks good!
packages/dioxus-blitz/src/lib.rs
Outdated
width: 800., | ||
height: 800., |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default window size has changed here. Can we have the height of 600 back (because some laptop only have room for 600px!)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man you're fast 😆 thanks!
@matthunz Are you actually able to compile and run Blitz on mobile? And if so, how might I go about doing that? |
Yeah it’s been alright to at least get it running on Android, I have a repo for testing here https://github.com/matthunz/blitz-android As for iOS I’ve gotten dioxus-desktop to work but I haven’t tried Blitz yet 🤔 I feel like if desktop is working though Blitz there should be in the same state as Android. Mobile does seem like we’ll need a lot of platform-specific code going forward, but I think once we have touch we can get pretty far as is. |
Skips setting the default window size to 800x600 when compiling for mobile
Fixes #124