Hot reloading support #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoburns
requested changes
Jun 23, 2024
| euclid = { version = "0.22", features = ["serde"] } | ||
| # mozbuild = "0.1.0" | ||
|
|
||
| [dev-dependencies] | ||
| blitz = { path = "./packages/blitz" } |
There was a problem hiding this comment.
Could this change be causing the examples not to work correctly?
packages/dioxus-blitz/Cargo.toml
Outdated
Comment on lines
15
to
16
| dioxus-cli-config = { git = "https://github.com/dioxuslabs/dioxus", rev = "a3aa6ae771a2d0a4d8cb6055c41efc0193b817ef"} | ||
| dioxus-hot-reload = { git = "https://github.com/dioxuslabs/dioxus", rev = "a3aa6ae771a2d0a4d8cb6055c41efc0193b817ef"} |
There was a problem hiding this comment.
These should be optional, based on the hot-reload feature.
packages/dom/src/document.rs
Outdated
Comment on lines
220
to
227
| let parent_id = node.parent.unwrap(); | ||
|
|
||
| // Get this node's parent, or the root node if it has none. | ||
| let parent_id = node.parent.unwrap_or_default(); |
There was a problem hiding this comment.
This doesn't seem right. Only the root node should have no parent. And we wouldn't want to insert a child of the root node instead of a sibling. What is the use case here? Replacing the root node?
There was a problem hiding this comment.
I don't think this should be necessary. The root node should be ElementId(0) and every node except that node should have a parent in dioxus mutations. Dioxus will never insert a node after or before ElementId(0)
ealmloff
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects
blitzto thedioxus-hot-reloadcrate by propagatingtaoevents to theDioxusDocument.Blitz examples still don't seem to work correctly, I think it has something to do with the virtual manifest?