Follow up for winit backend and CI
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthunz
force-pushed
the
mh/fix-winit-plus-cross
branch
3 times, most recently
from
f6f493a
to
737bcb8
Compare
matthunz
changed the title
winit backendwinit backend and CI
matthunz
force-pushed
the
mh/fix-winit-plus-cross
branch
4 times, most recently
from
3952a90
to
a4a916d
Compare
matthunz
force-pushed
the
mh/fix-winit-plus-cross
branch
from
a4a916d
to
b5da98f
Compare
jkelleyrtp
merged commit f025d19
into
DioxusLabs:jk/fix-winit-plus-cross
8 checks passed
nicoburns
pushed a commit
that referenced
this pull request
Jun 20, 2024
* fix cross-platform winit with muda bar fixes also wire up better CI * Follow up for `winit` backend and CI (#77) * Fix menu on windows * Refactor menu initialization * Fix missing gtk in CI * Create CONTRIBUTING.MD * Add info text --------- Co-authored-by: Matt Hunzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Menu bar
Viewtao. I'd love to dig deeper into this but I'm not sure how we can access a potentialgtk::Windowfrom thewinit::Windowyet.CI