Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add draw by timeout/disconnect/stall/illegal move #687

Closed
wants to merge 8 commits into from

Conversation

gahtan-syarif
Copy link
Contributor

@gahtan-syarif gahtan-syarif commented Aug 25, 2024

make fc consistent with fide and uscf rules as well as with cutechess

fix #410

@gahtan-syarif
Copy link
Contributor Author

gahtan-syarif commented Aug 25, 2024

+ grep 'Finished game'
+ sort -n -k 3
+ diff ./cutechess-cli-out.finished ./fastchess-out.finished
35c35
< Finished game 35 (sf_1 vs sf_2): 1/2-1/2 {Draw by adjudication}
---
> Finished game 35 (sf_1 vs sf_2): 1/2-1/2 {Draw by insufficient mating material}

how do i access the pgn for this?

edit: nvm found it

@gahtan-syarif
Copy link
Contributor Author

done 👍

@gahtan-syarif
Copy link
Contributor Author

Btw finding all the situations in which only one side has no legal set of moves for checkmate is quite complex, so i decided to take the cutechess route of doing it by adjudicating as draws when the opponent only has a lone king: cutechess/cutechess#717

@Disservin
Copy link
Owner

mh does cutechess have the same termination strings? i find this weird tbh, maybe it should be behind a "strict fide" feature but i don't care too much about that as of now because it's not the main focus

@gahtan-syarif
Copy link
Contributor Author

Yeah cutechess has the same termination strings

@Disservin
Copy link
Owner

Disservin commented Oct 1, 2024

mh.. i don't really like this, fc is primarily to test engines, we don't need 100% fide compliance, if we did then the first illegal move should be ignored and the engine asked to make another move and only lose on the second move. Making the engine lose in 100% of the cases is more consistent imo

@Disservin Disservin closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draw by timeout
2 participants