-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some tweaks to the app (fixed duplicates and added option to show age this year) #4
Open
eblis
wants to merge
36
commits into
Djonique:master
Choose a base branch
from
eblis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initially importing contacts you could end up with duplicated accounts if you had more than one google account you were importing from.
Added ability to show the age the person is turning to (or has turned to) this year.
I haven't tested the upgrade path in great detail, there might be some problems there as I've changed an int value (for the CURRENT / FUTURE ages) into an |
…erson. Instead of being able to only add a single extra notification (either 1 day, 2 days, 3 days, 1 week or 2 weeks beforehand) you can add any/all of these.
…well as birthdays.
…r each person for each anniversary. Instead a single, recurring alarm is created that checks for all anniversaries that we need to notify for. Added library joda-time to help with date handling, date manipulations and fix problems with inconsistencies between days to birthday, days from birth and other problems. Added notification colors for birthdays that are near. Added colors for All Fragment page for birthdays that are near.
Made sure notifications are sent in order. WIP: Attempt to make ads work again.
Allow user to edit anniversary type label.
… adding contacts.
…l point to the same one.
Clicking on picture or date of birth will bring up contact details window.
Update wording (especially in French)
…lect contact method.
…tween time zones with more than 24h between them.
…hes) Attempt to fix battery issues on very strict OSes. Clicking on a birthday notification will open the details activity again (fixed bug). Updated library versions to latest available ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problem where duplicate contacts could occur when initially added to the database.
Added option to show the age that a person turns to this year (regardless of their actual birthday and current date) - mostly I'm interested to see how old a person will be this current year, but don't really care if their birthday has passed (they've already turned) or their birthday is still upcoming (they're about to turn this age).
Also reworked the way separators are handled, removed the individual boolean flags for each month.
Preparing the ground for anniversaries.