Exclude DST consistently #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If source code finds a datetime without DST looking forward while test code finds the a datetime without DST looking backward, the UTC offset found may not be consistent.
|
This will unblock all other dependency update PRs. |
lefcha
approved these changes
Oct 5, 2023
|
It's almost just a refactor... but it's a fix as well. The issue was that our runtime code was looking forward to find non-DST-affected datetime, while the tests were looking backward. This led to inconsistencies. The change is a refactor in the sense that now both use the same function, and a fix in the sense that both use the same approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparing Thomas from yet another review, could you help me with this one @lefcha? 😊