-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dokploy): exclude password column from application queries #645
base: canary
Are you sure you want to change the base?
fix(dokploy): exclude password column from application queries #645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a doubt here, what happens if we have already saved a password, and we re-save the docker provider?
I think it would clean the password and this would lead to every time we make a change we have to enter the password.
Yes you're right, it doesn't appear in the dashboard anymore but it stays in the database, maybe we should store a variable if the password has been set or maybe the password length and display stars in the dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you make sure this works?
It doesn't work because the method that builds the docker needs the password and uses the method you modified.
This also breaks the types where the method you modified is used.
I may overlooked this, i moved the code to hide the password in the router instead of the services and i adapted the data where the route is called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the suggestions
Done |
fix the lint @jmischler72 |
No description provided.